Unverified Commit 4b381cf4 authored by Jean Delvare's avatar Jean Delvare Committed by Arnd Bergmann
Browse files

drivers/soc/litex: drop obsolete dependency on COMPILE_TEST 



Since commit 0166dc11 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

As a minor optimization, this also lets us drop of_match_ptr() and
ifdef-guarding, as we now know what they will resolve to, we might as
well save cpp some work.

Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Reviewed-by: default avatarGabriel Somlo <gsomlo@gmail.com>
Cc: Karol Gugala <kgugala@antmicro.com>
Cc: Mateusz Holenko <mholenko@antmicro.com>
Cc: Joel Stanley <joel@jms.id.au>
Link: https://lore.kernel.org/r/20240617133004.59887629@endymion.delvare


Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 94811b40

drivers/soc/litex/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ config LITEX 


config LITEX_SOC_CONTROLLER

	tristate "Enable LiteX SoC Controller driver"

	depends on OF || COMPILE_TEST

	depends on OF

	depends on HAS_IOMEM

	select LITEX

	help

drivers/soc/litex/litex_soc_ctrl.c

+1 −3
Original line number Diff line number Diff line
@@ -82,13 +82,11 @@ static int litex_reset_handler(struct notifier_block *this, unsigned long mode, 
	return NOTIFY_DONE;

}



#ifdef CONFIG_OF

static const struct of_device_id litex_soc_ctrl_of_match[] = {

	{.compatible = "litex,soc-controller"},

	{},

};

MODULE_DEVICE_TABLE(of, litex_soc_ctrl_of_match);

#endif /* CONFIG_OF */



static int litex_soc_ctrl_probe(struct platform_device *pdev)

{
@@ -130,7 +128,7 @@ static void litex_soc_ctrl_remove(struct platform_device *pdev) 
static struct platform_driver litex_soc_ctrl_driver = {

	.driver = {

		.name = "litex-soc-controller",

		.of_match_table = of_match_ptr(litex_soc_ctrl_of_match)

		.of_match_table = litex_soc_ctrl_of_match,

	},

	.probe = litex_soc_ctrl_probe,

	.remove_new = litex_soc_ctrl_remove,