Unverified Commit 4baaddaa authored by Felix Gu's avatar Felix Gu Committed by Mark Brown
Browse files

regulator: bq257xx: Fix device node reference leak in bq257xx_reg_dt_parse_gpio() 



In bq257xx_reg_dt_parse_gpio(), if fails to get subchild, it returns
without calling of_node_put(child), causing the device node reference
leak.

Fixes: 981dd162 ("regulator: bq257xx: Add bq257xx boost regulator driver")
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260224-bq257-v1-1-8ebbc731c1c3@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0902010c

drivers/regulator/bq257xx-regulator.c

+1 −2
Original line number Diff line number Diff line
@@ -115,11 +115,10 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_device *pdev) 
		return;



	subchild = of_get_child_by_name(child, pdata->desc.of_match);

	of_node_put(child);

	if (!subchild)

		return;



	of_node_put(child);



	pdata->otg_en_gpio = devm_fwnode_gpiod_get_index(&pdev->dev,

							 of_fwnode_handle(subchild),

							 "enable", 0,