Commit 4c59c59e authored by Nick Chan's avatar Nick Chan Committed by Greg Kroah-Hartman
Browse files

tty: serial: samsung: Use bit manipulation macros for APPLE_S5L_* 



New entries using BIT() will be added soon, so change the existing ones to
use bit manipulation macros including BIT() and GENMASK() for
consistency.

Suggested-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Tested-by: default avatarJanne Grunau <j@jannau.net>
Reviewed-by: default avatarNeal Gompa <neal@gompa.dev>
Signed-off-by: default avatarNick Chan <towinchenmi@gmail.com>
Reviewed-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20240911050741.14477-2-towinchenmi@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f16dd10b

include/linux/serial_s3c.h

+7 −7
Original line number Diff line number Diff line
@@ -249,9 +249,9 @@ 
#define APPLE_S5L_UCON_RXTO_ENA		9

#define APPLE_S5L_UCON_RXTHRESH_ENA	12

#define APPLE_S5L_UCON_TXTHRESH_ENA	13

#define APPLE_S5L_UCON_RXTO_ENA_MSK	(1 << APPLE_S5L_UCON_RXTO_ENA)

#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK	(1 << APPLE_S5L_UCON_RXTHRESH_ENA)

#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK	(1 << APPLE_S5L_UCON_TXTHRESH_ENA)

#define APPLE_S5L_UCON_RXTO_ENA_MSK	BIT(APPLE_S5L_UCON_RXTO_ENA)

#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK	BIT(APPLE_S5L_UCON_RXTHRESH_ENA)

#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK	BIT(APPLE_S5L_UCON_TXTHRESH_ENA)



#define APPLE_S5L_UCON_DEFAULT		(S3C2410_UCON_TXIRQMODE | \

					 S3C2410_UCON_RXIRQMODE | \
@@ -260,10 +260,10 @@ 
					 APPLE_S5L_UCON_RXTHRESH_ENA_MSK | \

					 APPLE_S5L_UCON_TXTHRESH_ENA_MSK)



#define APPLE_S5L_UTRSTAT_RXTHRESH	(1<<4)

#define APPLE_S5L_UTRSTAT_TXTHRESH	(1<<5)

#define APPLE_S5L_UTRSTAT_RXTO		(1<<9)

#define APPLE_S5L_UTRSTAT_ALL_FLAGS	(0x3f0)

#define APPLE_S5L_UTRSTAT_RXTHRESH	BIT(4)

#define APPLE_S5L_UTRSTAT_TXTHRESH	BIT(5)

#define APPLE_S5L_UTRSTAT_RXTO		BIT(9)

#define APPLE_S5L_UTRSTAT_ALL_FLAGS	GENMASK(9, 4)



#ifndef __ASSEMBLY__