Unverified Commit 4d253425 authored by Shuicheng Lin's avatar Shuicheng Lin Committed by Rodrigo Vivi
Browse files

drm/xe/oa: Fix exec_queue leak on width check in stream open 



In xe_oa_stream_open_ioctl(), when param.exec_q->width > 1 the
function returns -EOPNOTSUPP directly, skipping the existing
err_exec_q cleanup path. The exec_queue reference obtained by
xe_exec_queue_lookup() is leaked.

The exec queue holds a reference on the xe_file, which is only
dropped during queue teardown. The leaked lookup ref is not on
the file's exec_queue xarray, so file close cannot release it.
This keeps both the exec queue and the file private state pinned
indefinitely.

Jump to err_exec_q instead of returning directly so the reference
is released.

Fixes: f0ed3983 ("xe/oa: Fix query mode of operation for OAR/OAC")
Assisted-by: Claude:claude-opus-4.6
Reviewed-by: default avatarAshutosh Dixit <ashutosh.dixit@intel.com>
Link: https://patch.msgid.link/20260514203210.593488-1-shuicheng.lin@intel.com


Signed-off-by: default avatarShuicheng Lin <shuicheng.lin@intel.com>
(cherry picked from commit 339fa0be9e4a5d69fa47e91f4a36574224fb478f)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 00907da2

drivers/gpu/drm/xe/xe_oa.c

+4 −2
Original line number Diff line number Diff line
@@ -2032,8 +2032,10 @@ int xe_oa_stream_open_ioctl(struct drm_device *dev, u64 data, struct drm_file *f 
		if (XE_IOCTL_DBG(oa->xe, !param.exec_q))

			return -ENOENT;



		if (XE_IOCTL_DBG(oa->xe, param.exec_q->width > 1))

			return -EOPNOTSUPP;

		if (XE_IOCTL_DBG(oa->xe, param.exec_q->width > 1)) {

			ret = -EOPNOTSUPP;

			goto err_exec_q;

		}

	}



	/*