Commit 4d690e50 authored by AngeloGioacchino Del Regno's avatar AngeloGioacchino Del Regno Committed by Thierry Reding
Browse files

pwm: pwm-mediatek: Beautify error messages text 



As a cherry-on-top cleanup, make error messages clearer to read
by changing instances of "clock: XXXX failed" to a more readable
"Failed to get XXXX clock". Also add "of" to unsupported period
error.

This is purely a cosmetic change; no "real" functional changes.

Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: default avatarMacpaul Lin <macpaul.lin@mediatek.com>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 446925f1

drivers/pwm/pwm-mediatek.c

+4 −4
Original line number Diff line number Diff line
@@ -146,7 +146,7 @@ static int pwm_mediatek_config(struct pwm_chip *chip, struct pwm_device *pwm, 


	if (clkdiv > PWM_CLK_DIV_MAX) {

		pwm_mediatek_clk_disable(chip, pwm);

		dev_err(chip->dev, "period %d not supported\n", period_ns);

		dev_err(chip->dev, "period of %d ns not supported\n", period_ns);

		return -EINVAL;

	}
@@ -229,12 +229,12 @@ static int pwm_mediatek_probe(struct platform_device *pdev) 
	pc->clk_top = devm_clk_get(&pdev->dev, "top");

	if (IS_ERR(pc->clk_top))

		return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk_top),

				     "clock: top failed\n");

				     "Failed to get top clock\n");



	pc->clk_main = devm_clk_get(&pdev->dev, "main");

	if (IS_ERR(pc->clk_main))

		return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk_main),

				     "clock: main failed\n");

				     "Failed to get main clock\n");



	for (i = 0; i < pc->soc->num_pwms; i++) {

		char name[8];
@@ -244,7 +244,7 @@ static int pwm_mediatek_probe(struct platform_device *pdev) 
		pc->clk_pwms[i] = devm_clk_get(&pdev->dev, name);

		if (IS_ERR(pc->clk_pwms[i]))

			return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk_pwms[i]),

					     "clock: %s failed\n", name);

					     "Failed to get %s clock\n", name);

	}



	pc->chip.dev = &pdev->dev;