Commit 4d8690da authored by Henrique Carvalho's avatar Henrique Carvalho Committed by Steve French
Browse files

smb: client: protect tc_count increment in smb2_find_smb_sess_tcon_unlocked() 



Commit 96c4af41 ("cifs: Fix locking usage for tcon fields")
refactored cifs code to change cifs_tcp_ses_lock for tc_lock around
tc_count changes.

There was missing lock around tc_count increment inside
smb2_find_smb_sess_tcon_unlocked().

Cc: stable@vger.kernel.org
Fixes: 96c4af41 ("cifs: Fix locking usage for tcon fields")
Reviewed-by: default avatarShyam Prasad N <sprasad@microsoft.com>
Signed-off-by: default avatarHenrique Carvalho <henrique.carvalho@suse.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 5200f5f4

fs/smb/client/smb2transport.c

+2 −0
Original line number Diff line number Diff line
@@ -169,7 +169,9 @@ smb2_find_smb_sess_tcon_unlocked(struct cifs_ses *ses, __u32 tid) 
	list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {

		if (tcon->tid != tid)

			continue;

		spin_lock(&tcon->tc_lock);

		++tcon->tc_count;

		spin_unlock(&tcon->tc_lock);

		trace_smb3_tcon_ref(tcon->debug_id, tcon->tc_count,

				    netfs_trace_tcon_ref_get_find_sess_tcon);

		return tcon;