Commit 4de7b17f authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Ingo Molnar
Browse files

sched: Assert for_each_thread() is properly locked 



list_for_each_entry_rcu() takes an optional fourth argument which
allows RCU to assert that the correct lock is held.  Several callers
of for_each_thread() rely on their caller to be holding the appropriate
lock, so this is a useful assertion to include.

Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarJoel Fernandes (Google) <joel@joelfernandes.org>
Link: https://lore.kernel.org/r/20230821134428.2504912-1-willy@infradead.org
parent 0e34600a

include/linux/sched/signal.h

+2 −1
Original line number Diff line number Diff line
@@ -656,7 +656,8 @@ extern bool current_is_single_threaded(void); 
	while ((t = next_thread(t)) != g)



#define __for_each_thread(signal, t)	\

	list_for_each_entry_rcu(t, &(signal)->thread_head, thread_node)

	list_for_each_entry_rcu(t, &(signal)->thread_head, thread_node, \

		lockdep_is_held(&tasklist_lock))



#define for_each_thread(p, t)		\

	__for_each_thread((p)->signal, t)