Commit 4df105f0 authored by Wenchao Hao's avatar Wenchao Hao Committed by Martin K. Petersen
Browse files

scsi: libfc: Fix potential NULL pointer dereference in fc_lport_ptp_setup() 



fc_lport_ptp_setup() did not check the return value of fc_rport_create()
which can return NULL and would cause a NULL pointer dereference. Address
this issue by checking return value of fc_rport_create() and log error
message on fc_rport_create() failed.

Signed-off-by: default avatarWenchao Hao <haowenchao2@huawei.com>
Link: https://lore.kernel.org/r/20231011130350.819571-1-haowenchao2@huawei.com


Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f42706a8

drivers/scsi/libfc/fc_lport.c

+6 −0
Original line number Diff line number Diff line
@@ -241,6 +241,12 @@ static void fc_lport_ptp_setup(struct fc_lport *lport, 
	}

	mutex_lock(&lport->disc.disc_mutex);

	lport->ptp_rdata = fc_rport_create(lport, remote_fid);

	if (!lport->ptp_rdata) {

		printk(KERN_WARNING "libfc: Failed to setup lport 0x%x\n",

			lport->port_id);

		mutex_unlock(&lport->disc.disc_mutex);

		return;

	}

	kref_get(&lport->ptp_rdata->kref);

	lport->ptp_rdata->ids.port_name = remote_wwpn;

	lport->ptp_rdata->ids.node_name = remote_wwnn;