Commit 4e51141f authored by Antonio Quartulli's avatar Antonio Quartulli
Browse files

ovpn: set skb->ignore_df = 1 before sending IPv6 packets out 



IPv6 user packets (sent over the tunnel) may be larger than
the outgoing interface MTU after encapsulation.
When this happens ovpn should allow the kernel to fragment
them because they are "locally generated".

To achieve the above, we must set skb->ignore_df = 1
so that ip6_fragment() can be made aware of this decision.

Failing to do so will result in ip6_fragment() dropping
the packet thinking it was "routed".

No change is required in the IPv4 path, because when
calling udp_tunnel_xmit_skb() we already pass the
'df' argument set to 0, therefore the resulting datagram
is allowed to be fragmented if need be.

Fixes: 08857b5e ("ovpn: implement basic TX path (UDP)")
Reported-by: default avatarGert Doering <gert@greenie.muc.de>
Closes: https://github.com/OpenVPN/ovpn-net-next/issues/3


Tested-by: default avatarGert Doering <gert@greenie.muc.de>
Acked-by: Gert Doering <gert@greenie.muc.de> # as primary user
Link: https://mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31577.html


Signed-off-by: default avatarAntonio Quartulli <antonio@openvpn.net>
parent 142e17cf

drivers/net/ovpn/udp.c

+10 −0
Original line number Diff line number Diff line
@@ -262,6 +262,16 @@ static int ovpn_udp6_output(struct ovpn_peer *peer, struct ovpn_bind *bind, 
	dst_cache_set_ip6(cache, dst, &fl.saddr);



transmit:

	/* user IPv6 packets may be larger than the transport interface

	 * MTU (after encapsulation), however, since they are locally

	 * generated we should ensure they get fragmented.

	 * Setting the ignore_df flag to 1 will instruct ip6_fragment() to

	 * fragment packets if needed.

	 *

	 * NOTE: this is not needed for IPv4 because we pass df=0 to

	 * udp_tunnel_xmit_skb()

	 */

	skb->ignore_df = 1;

	udp_tunnel6_xmit_skb(dst, sk, skb, skb->dev, &fl.saddr, &fl.daddr, 0,

			     ip6_dst_hoplimit(dst), 0, fl.fl6_sport,

			     fl.fl6_dport, udp_get_no_check6_tx(sk));