Commit 4ef7c6d3 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Chandan Babu R
Browse files

xfs: use kfree_rcu_mightsleep to free the perag structures 



Using the kfree_rcu_mightsleep is simpler and removes the need for a
rcu_head in the perag structure.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarChandan Babu R <chandanbabu@kernel.org>
parent 70045daf

fs/xfs/libxfs/xfs_ag.c

+1 −11
Original line number Diff line number Diff line
@@ -235,16 +235,6 @@ xfs_initialize_perag_data( 
	return error;

}



STATIC void

__xfs_free_perag(

	struct rcu_head	*head)

{

	struct xfs_perag *pag = container_of(head, struct xfs_perag, rcu_head);



	ASSERT(!delayed_work_pending(&pag->pag_blockgc_work));

	kfree(pag);

}



/*

 * Free up the per-ag resources associated with the mount structure.

 */
@@ -270,7 +260,7 @@ xfs_free_perag( 
		xfs_perag_rele(pag);

		XFS_IS_CORRUPT(pag->pag_mount,

				atomic_read(&pag->pag_active_ref) != 0);

		call_rcu(&pag->rcu_head, __xfs_free_perag);

		kfree_rcu_mightsleep(pag);

	}

}

fs/xfs/libxfs/xfs_ag.h

+0 −3
Original line number Diff line number Diff line
@@ -63,9 +63,6 @@ struct xfs_perag { 
	/* Blocks reserved for the reverse mapping btree. */

	struct xfs_ag_resv	pag_rmapbt_resv;



	/* for rcu-safe freeing */

	struct rcu_head	rcu_head;



	/* Precalculated geometry info */

	xfs_agblock_t		block_count;

	xfs_agblock_t		min_block;