Commit 4f4fcafd authored by Nirmoy Das's avatar Nirmoy Das Committed by Matthew Auld
Browse files

drm/xe: Fix potential integer overflow in page size calculation 



Explicitly cast tbo->page_alignment to u64 before bit-shifting to
prevent overflow when assigning to min_page_size.

Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: default avatarNirmoy Das <nirmoy.das@intel.com>
Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240318164342.3094-1-nirmoy.das@intel.com
parent 1d3c8305

drivers/gpu/drm/xe/xe_ttm_vram_mgr.c

+1 −1
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ static int xe_ttm_vram_mgr_new(struct ttm_resource_manager *man, 


	min_page_size = mgr->default_page_size;

	if (tbo->page_alignment)

		min_page_size = tbo->page_alignment << PAGE_SHIFT;

		min_page_size = (u64)tbo->page_alignment << PAGE_SHIFT;



	if (WARN_ON(min_page_size < mm->chunk_size)) {

		err = -EINVAL;