Commit 4f86eb0a authored by Wang Liang's avatar Wang Liang Committed by Paolo Abeni
Browse files

selftests: net: check jq command is supported 



The jq command is used in vlan_bridge_binding.sh, if it is not supported,
the test will spam the following log.

  # ./vlan_bridge_binding.sh: line 51: jq: command not found
  # ./vlan_bridge_binding.sh: line 51: jq: command not found
  # ./vlan_bridge_binding.sh: line 51: jq: command not found
  # ./vlan_bridge_binding.sh: line 51: jq: command not found
  # ./vlan_bridge_binding.sh: line 51: jq: command not found
  # TEST: Test bridge_binding on->off when lower down                   [FAIL]
  #       Got operstate of , expected 0

The rtnetlink.sh has the same problem. It makes sense to check if jq is
installed before running these tests. After this patch, the
vlan_bridge_binding.sh skipped if jq is not supported:

  # timeout set to 3600
  # selftests: net: vlan_bridge_binding.sh
  # TEST: jq not installed                                              [SKIP]

Fixes: dca12e9a ("selftests: net: Add a VLAN bridge binding selftest")
Fixes: 6a414fd7 ("selftests: rtnetlink: Add an address proto test")
Signed-off-by: default avatarWang Liang <wangliang74@huawei.com>
Reviewed-by: default avatarHangbin Liu <liuhangbin@gmail.com>
Link: https://patch.msgid.link/20251013080039.3035898-1-wangliang74@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent bd5afca1

tools/testing/selftests/net/rtnetlink.sh

+2 −0
Original line number Diff line number Diff line
@@ -1466,6 +1466,8 @@ usage: ${0##*/} OPTS 
EOF

}



require_command jq



#check for needed privileges

if [ "$(id -u)" -ne 0 ];then

	end_test "SKIP: Need root privileges"

tools/testing/selftests/net/vlan_bridge_binding.sh

+2 −0
Original line number Diff line number Diff line
@@ -249,6 +249,8 @@ test_binding_toggle_off_when_upper_down() 
	do_test_binding_off : "on->off when upper down"

}



require_command jq



trap defer_scopes_cleanup EXIT

setup_prepare

tests_run