Unverified Commit 50096966 authored by Anand Moon's avatar Anand Moon Committed by Krzysztof Wilczyński
Browse files

PCI: rockchip: Refactor rockchip_pcie_disable_clocks() signature 

Refactor rockchip_pcie_disable_clocks() to accept a struct rockchip_pcie
pointer instead of a void pointer thus improving type safety and code
readability by explicitly specifying the expected data type.

Link: https://lore.kernel.org/r/20241202151150.7393-4-linux.amoon@gmail.com


Signed-off-by: default avatarAnand Moon <linux.amoon@gmail.com>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent 18715931

drivers/pci/controller/pcie-rockchip.c

+1 −2
Original line number Diff line number Diff line
@@ -270,9 +270,8 @@ int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip) 
}

EXPORT_SYMBOL_GPL(rockchip_pcie_enable_clocks);



void rockchip_pcie_disable_clocks(void *data)

void rockchip_pcie_disable_clocks(struct rockchip_pcie *rockchip)

{

	struct rockchip_pcie *rockchip = data;



	clk_bulk_disable_unprepare(rockchip->num_clks, rockchip->clks);

}

drivers/pci/controller/pcie-rockchip.h

+1 −1
Original line number Diff line number Diff line
@@ -369,7 +369,7 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip); 
int rockchip_pcie_get_phys(struct rockchip_pcie *rockchip);

void rockchip_pcie_deinit_phys(struct rockchip_pcie *rockchip);

int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip);

void rockchip_pcie_disable_clocks(void *data);

void rockchip_pcie_disable_clocks(struct rockchip_pcie *rockchip);

void rockchip_pcie_cfg_configuration_accesses(

		struct rockchip_pcie *rockchip, u32 type);