Commit 505c9530 authored by Sean Christopherson's avatar Sean Christopherson
Browse files

KVM: selftests: Isolate the guest_memfd Copy-on-Write negative testcase 



Move the guest_memfd Copy-on-Write (CoW) testcase to its own function to
better separate positive testcases from negative testcases.

No functional change intended.

Suggested-by: default avatarAckerley Tng <ackerleytng@google.com>
Reviewed-by: default avatarAckerley Tng <ackerleytng@google.com>
Tested-by: default avatarAckerley Tng <ackerleytng@google.com>
Link: https://lore.kernel.org/r/20251003232606.4070510-11-seanjc@google.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 61cee97f

tools/testing/selftests/kvm/guest_memfd_test.c

+9 −3
Original line number Diff line number Diff line
@@ -40,6 +40,14 @@ static void test_file_read_write(int fd, size_t total_size) 
		    "pwrite on a guest_mem fd should fail");

}



static void test_mmap_cow(int fd, size_t size)

{

	void *mem;



	mem = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0);

	TEST_ASSERT(mem == MAP_FAILED, "Copy-on-write not allowed by guest_memfd.");

}



static void test_mmap_supported(int fd, size_t total_size)

{

	const char val = 0xaa;
@@ -47,9 +55,6 @@ static void test_mmap_supported(int fd, size_t total_size) 
	size_t i;

	int ret;



	mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0);

	TEST_ASSERT(mem == MAP_FAILED, "Copy-on-write not allowed by guest_memfd.");



	mem = kvm_mmap(total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd);



	memset(mem, val, total_size);
@@ -272,6 +277,7 @@ static void __test_guest_memfd(struct kvm_vm *vm, uint64_t flags) 


	if (flags & GUEST_MEMFD_FLAG_MMAP) {

		gmem_test(mmap_supported, vm, flags);

		gmem_test(mmap_cow, vm, flags);

		gmem_test(fault_overflow, vm, flags);

	} else {

		gmem_test(mmap_not_supported, vm, flags);