Commit 50a191a8 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Joel Granados
Browse files

sysctl: update comments to new registration APIs 



The sysctl registration APIs do not need a terminating table entry
anymore and with commit acc15469 ("sysctl: Warn on an empty procname
element") even emit warnings if such a sentinel entry is supplied.

While at it also remove the mention of "table->de" which was removed in
commit 3fbfa981 ("[PATCH] sysctl: remove the proc_dir_entry member
for the sysctl tables") back in 2007.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Reviewed-by: default avatarKees Cook <kees@kernel.org>
Signed-off-by: default avatarJoel Granados <joel.granados@kernel.org>
parent 7701ab78

include/linux/sysctl.h

+2 −4
Original line number Diff line number Diff line
@@ -90,9 +90,7 @@ int proc_do_static_key(const struct ctl_table *table, int write, void *buffer, 


/*

 * Register a set of sysctl names by calling register_sysctl

 * with an initialised array of struct ctl_table's.  An entry with 

 * NULL procname terminates the table.  table->de will be

 * set up by the registration and need not be initialised in advance.

 * with an initialised array of struct ctl_table's.

 *

 * sysctl names can be mirrored automatically under /proc/sys.  The

 * procname supplied controls /proc naming.
@@ -133,7 +131,7 @@ static inline void *proc_sys_poll_event(struct ctl_table_poll *poll) 


/* A sysctl table is an array of struct ctl_table: */

struct ctl_table {

	const char *procname;		/* Text ID for /proc/sys, or zero */

	const char *procname;		/* Text ID for /proc/sys */

	void *data;

	int maxlen;

	umode_t mode;