Commit 51c88429 authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Paolo Abeni
Browse files

net: dsa: realtek: Use for_each_child_of_node_scoped() 



Avoid need to manually handle of_node_put() by using
for_each_child_of_node_scoped(), which can simplfy code.

Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 81b4eb62

drivers/net/dsa/realtek/rtl8366rb.c

+3 −5
Original line number Diff line number Diff line
@@ -1009,8 +1009,8 @@ static int rtl8366rb_setup_all_leds_off(struct realtek_priv *priv) 


static int rtl8366rb_setup_leds(struct realtek_priv *priv)

{

	struct device_node *leds_np, *led_np;

	struct dsa_switch *ds = &priv->ds;

	struct device_node *leds_np;

	struct dsa_port *dp;

	int ret = 0;
@@ -1025,14 +1025,12 @@ static int rtl8366rb_setup_leds(struct realtek_priv *priv) 
			continue;

		}



		for_each_child_of_node(leds_np, led_np) {

		for_each_child_of_node_scoped(leds_np, led_np) {

			ret = rtl8366rb_setup_led(priv, dp,

						  of_fwnode_handle(led_np));

			if (ret) {

				of_node_put(led_np);

			if (ret)

				break;

		}

		}



		of_node_put(leds_np);

		if (ret)