Commit 51df9476 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Jakub Kicinski
Browse files

octeontx2-pf: fix netdev memory leak in rvu_rep_create() 



When rvu_rep_devlink_port_register() fails, free_netdev(ndev) for this
incomplete iteration before going to "exit:" label.

Fixes: 9ed0343f ("octeontx2-pf: Add devlink port support")
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://patch.msgid.link/20241217052326.1086191-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5eecd85c

drivers/net/ethernet/marvell/octeontx2/nic/rep.c

+3 −1
Original line number Diff line number Diff line
@@ -680,8 +680,10 @@ int rvu_rep_create(struct otx2_nic *priv, struct netlink_ext_ack *extack) 
		ndev->features |= ndev->hw_features;

		eth_hw_addr_random(ndev);

		err = rvu_rep_devlink_port_register(rep);

		if (err)

		if (err) {

			free_netdev(ndev);

			goto exit;

		}



		SET_NETDEV_DEVLINK_PORT(ndev, &rep->dl_port);

		err = register_netdev(ndev);