Commit 5232e849 authored by Boris Brezillon's avatar Boris Brezillon
Browse files

drm/panthor: Don't try to enable extract events 



Not only this only works once, because of how extract events work
(event is enabled if the req and ack bit differ, and it's signalled
by the FW by setting identical req and ack, to re-enable the event,
we need to toggle the bit, which we never do). But more importantly,
we never do anything with this event, so we're better off dropping it
when programming the CS slot.

v2:
- Add R-b

v3:
- Collect R-b

Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Reviewed-by: default avatarChia-I Wu <olvaffe@gmail.com>
Link: https://patch.msgid.link/20251128094839.3856402-3-boris.brezillon@collabora.com


Signed-off-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
parent 851f58d0

drivers/gpu/drm/panthor/panthor_sched.c

+2 −4
Original line number Diff line number Diff line
@@ -1180,12 +1180,10 @@ cs_slot_prog_locked(struct panthor_device *ptdev, u32 csg_id, u32 cs_id) 
	panthor_fw_update_reqs(cs_iface, req,

			       CS_IDLE_SYNC_WAIT |

			       CS_IDLE_EMPTY |

			       CS_STATE_START |

			       CS_EXTRACT_EVENT,

			       CS_STATE_START,

			       CS_IDLE_SYNC_WAIT |

			       CS_IDLE_EMPTY |

			       CS_STATE_MASK |

			       CS_EXTRACT_EVENT);

			       CS_STATE_MASK);

	if (queue->iface.input->insert != queue->iface.input->extract)

		queue_resume_timeout(queue);

}