Commit 52c22661 authored by Huacai Chen's avatar Huacai Chen
Browse files

LoongArch: Avoid using $r0/$r1 as "mask" for csrxchg 

When building kernel with LLVM there are occasionally such errors:

In file included from ./include/linux/spinlock.h:59:
In file included from ./include/linux/irqflags.h:17:
arch/loongarch/include/asm/irqflags.h:38:3: error: must not be $r0 or $r1
   38 |                 "csrxchg %[val], %[mask], %[reg]\n\t"
      |                 ^
<inline asm>:1:16: note: instantiated into assembly here
    1 |         csrxchg $a1, $ra, 0
      |                       ^

To prevent the compiler from allocating $r0 or $r1 for the "mask" of the
csrxchg instruction, the 'q' constraint must be used but Clang < 21 does
not support it. So force to use $t0 in the inline asm, in order to avoid
using $r0/$r1 while keeping the backward compatibility.

Cc: stable@vger.kernel.org
Link: https://github.com/llvm/llvm-project/pull/141037


Reviewed-by: default avatarYanteng Si <si.yanteng@linux.dev>
Suggested-by: default avatarWANG Rui <wangrui@loongson.cn>
Signed-off-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
parent a24f2fb7

arch/loongarch/include/asm/irqflags.h

+12 −4
Original line number Diff line number Diff line
@@ -14,40 +14,48 @@ 
static inline void arch_local_irq_enable(void)

{

	u32 flags = CSR_CRMD_IE;

	register u32 mask asm("t0") = CSR_CRMD_IE;



	__asm__ __volatile__(

		"csrxchg %[val], %[mask], %[reg]\n\t"

		: [val] "+r" (flags)

		: [mask] "r" (CSR_CRMD_IE), [reg] "i" (LOONGARCH_CSR_CRMD)

		: [mask] "r" (mask), [reg] "i" (LOONGARCH_CSR_CRMD)

		: "memory");

}



static inline void arch_local_irq_disable(void)

{

	u32 flags = 0;

	register u32 mask asm("t0") = CSR_CRMD_IE;



	__asm__ __volatile__(

		"csrxchg %[val], %[mask], %[reg]\n\t"

		: [val] "+r" (flags)

		: [mask] "r" (CSR_CRMD_IE), [reg] "i" (LOONGARCH_CSR_CRMD)

		: [mask] "r" (mask), [reg] "i" (LOONGARCH_CSR_CRMD)

		: "memory");

}



static inline unsigned long arch_local_irq_save(void)

{

	u32 flags = 0;

	register u32 mask asm("t0") = CSR_CRMD_IE;



	__asm__ __volatile__(

		"csrxchg %[val], %[mask], %[reg]\n\t"

		: [val] "+r" (flags)

		: [mask] "r" (CSR_CRMD_IE), [reg] "i" (LOONGARCH_CSR_CRMD)

		: [mask] "r" (mask), [reg] "i" (LOONGARCH_CSR_CRMD)

		: "memory");

	return flags;

}



static inline void arch_local_irq_restore(unsigned long flags)

{

	register u32 mask asm("t0") = CSR_CRMD_IE;



	__asm__ __volatile__(

		"csrxchg %[val], %[mask], %[reg]\n\t"

		: [val] "+r" (flags)

		: [mask] "r" (CSR_CRMD_IE), [reg] "i" (LOONGARCH_CSR_CRMD)

		: [mask] "r" (mask), [reg] "i" (LOONGARCH_CSR_CRMD)

		: "memory");

}