Commit 54296219 authored Jun 21, 2024 by Dave Stevenson

drm/vc4: plane: YUV planes require vertical scaling to always be enabled

It has been observed that a YUV422 unity scaled plane isn't displayed.
Enabling vertical scaling on the UV planes solves this. There is
already a similar clause to always enable horizontal scaling on the
UV planes.

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240621152055.4180873-16-dave.stevenson@raspberrypi.com

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

parent 52efe364

drivers/gpu/drm/vc4/vc4_plane.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -517,6 +517,12 @@ static int vc4_plane_setup_clipping_and_scaling(struct drm_plane_state *state)
		*/
		if (vc4_state->x_scaling[1] == VC4_SCALING_NONE)
		vc4_state->x_scaling[1] = VC4_SCALING_PPF;

		/* Similarly UV needs vertical scaling to be enabled.
		* Without this a 1:1 scaled YUV422 plane isn't rendered.
		*/
		if (vc4_state->y_scaling[1] == VC4_SCALING_NONE)
		vc4_state->y_scaling[1] = VC4_SCALING_PPF;
		} else {
		vc4_state->is_yuv = false;
		vc4_state->x_scaling[1] = VC4_SCALING_NONE;