Commit 5497ffe3 authored by Ondrej Jirman's avatar Ondrej Jirman Committed by Heiko Stuebner
Browse files

arm64: dts: rockchip: Fix voltage threshold for volume keys for Pinephone Pro 



Previously sometimes pressing the volume-down button would register as
a volume-up button. Match the thresholds as shown in the Pinephone Pro
schematic.

Tests:

~ $ evtest
    // Mashed the volume down ~100 times with varying intensity
    Event: time xxx, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 1
    Event: time xxx, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 0
    // Mashed the volume up ~100 times with varying intensity
    Event: time xxx, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 1
    Event: time xxx, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 0

Fixes: d3150ed5 ("arm64: dts: rockchip: Add support for volume keys to rk3399-pinephone-pro")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarOndrej Jirman <megi@xff.cz>
Signed-off-by: default avatarRudraksha Gupta <guptarud@gmail.com>
Reviewed-by: default avatarPavel Machek <pavel@ucw.cz>
Link: https://patch.msgid.link/20251124-ppp_light_accel_mag_vol-down-v5-4-f9a10a0a50eb@gmail.com


Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent 8f0b4cce

arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts

+2 −2
Original line number Diff line number Diff line
@@ -40,13 +40,13 @@ adc-keys { 
		button-up {

			label = "Volume Up";

			linux,code = <KEY_VOLUMEUP>;

			press-threshold-microvolt = <100000>;

			press-threshold-microvolt = <2000>;

		};



		button-down {

			label = "Volume Down";

			linux,code = <KEY_VOLUMEDOWN>;

			press-threshold-microvolt = <600000>;

			press-threshold-microvolt = <300000>;

		};

	};