Commit 54ba9071 authored by Kaushlendra Kumar's avatar Kaushlendra Kumar Committed by Rafael J. Wysocki
Browse files

ACPICA: acpidump: fix return values in ap_is_valid_checksum() 

The function ap_is_valid_checksum() has a boolean name suggesting it
should return TRUE/FALSE, but incorrectly returns AE_OK on success and
has no explicit return on failure, leading to undefined behavior.

Fix by returning proper values:
 - FALSE when checksum validation fails
 - TRUE when checksum validation succeeds

Link: https://github.com/acpica/acpica/commit/479ba862


Signed-off-by: default avatarKaushlendra Kumar <kaushlendra.kumar@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 81f92cff

tools/power/acpi/tools/acpidump/apdump.c

+2 −1
Original line number Diff line number Diff line
@@ -86,9 +86,10 @@ u8 ap_is_valid_checksum(struct acpi_table_header *table) 
	if (ACPI_FAILURE(status)) {

		fprintf(stderr, "%4.4s: Warning: wrong checksum in table\n",

			table->signature);

		return (FALSE);

	}



	return (AE_OK);

	return (TRUE);

}



/******************************************************************************