Commit 55580ad0 authored by Henrique Carvalho's avatar Henrique Carvalho Committed by Steve French
Browse files

smb: client: short-circuit in open_cached_dir_by_dentry() if !dentry 



When dentry is NULL, the current code acquires the spinlock and traverses
the entire list, but the condition (dentry && cfid->dentry == dentry)
ensures no match will ever be found.

Return -ENOENT early in this case, avoiding unnecessary lock acquisition
and list traversal.

Signed-off-by: default avatarHenrique Carvalho <henrique.carvalho@suse.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 2f6a4af0

fs/smb/client/cached_dir.c

+4 −1
Original line number Diff line number Diff line
@@ -416,9 +416,12 @@ int open_cached_dir_by_dentry(struct cifs_tcon *tcon, 
	if (cfids == NULL)

		return -EOPNOTSUPP;



	if (!dentry)

		return -ENOENT;



	spin_lock(&cfids->cfid_list_lock);

	list_for_each_entry(cfid, &cfids->entries, entry) {

		if (dentry && cfid->dentry == dentry) {

		if (cfid->dentry == dentry) {

			if (!is_valid_cached_dir(cfid))

				break;

			cifs_dbg(FYI, "found a cached file handle by dentry\n");