Commit 555c6e9b authored by Yicong Yang's avatar Yicong Yang Committed by Will Deacon
Browse files

drivers/perf: hisi: Set correct IRQ affinity for PMUs with no association 



For PMUs with no association, the hisi_pmu->on_cpu is initialized
according to the NUMA locality but use a wrong CPU for the interrupt
affinity. The CPU selected from cpumask_local_spread() can be different
from the CPU by the cpuhp callback. Fix this by setting the IRQ affinity
to hisi_pmu->on_cpu.

Fixes: 6cd13708 ("drivers/perf: hisi: Refactor the detection of associated CPUs")
Signed-off-by: default avatarYicong Yang <yangyicong@hisilicon.com>
Acked-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20241223125134.57885-1-yangyicong@huawei.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent f3edf03a

drivers/perf/hisilicon/hisi_uncore_pmu.c

+1 −1
Original line number Diff line number Diff line
@@ -510,7 +510,7 @@ int hisi_uncore_pmu_online_cpu(unsigned int cpu, struct hlist_node *node) 
			return 0;



		hisi_pmu->on_cpu = cpumask_local_spread(0, dev_to_node(hisi_pmu->dev));

		WARN_ON(irq_set_affinity(hisi_pmu->irq, cpumask_of(cpu)));

		WARN_ON(irq_set_affinity(hisi_pmu->irq, cpumask_of(hisi_pmu->on_cpu)));

		return 0;

	}