Commit 55c172c1 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Johannes Berg
Browse files

ssb: use new GPIO line value setter callbacks for the second GPIO chip 



Because the other chip is guarded in an unlikely ifdef, I missed it when
converting this driver. Fix it now.

Fixes: 757259db ("ssb: use new GPIO line value setter callbacks")
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250723141257.51412-1-brgl@bgdev.pl


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 41469ff9

drivers/ssb/driver_gpio.c

+5 −3
Original line number Diff line number Diff line
@@ -267,12 +267,14 @@ static int ssb_gpio_extif_get_value(struct gpio_chip *chip, unsigned int gpio) 
	return !!ssb_extif_gpio_in(&bus->extif, 1 << gpio);

}



static void ssb_gpio_extif_set_value(struct gpio_chip *chip, unsigned int gpio,

static int ssb_gpio_extif_set_value(struct gpio_chip *chip, unsigned int gpio,

				    int value)

{

	struct ssb_bus *bus = gpiochip_get_data(chip);



	ssb_extif_gpio_out(&bus->extif, 1 << gpio, value ? 1 << gpio : 0);



	return 0;

}



static int ssb_gpio_extif_direction_input(struct gpio_chip *chip,
@@ -420,7 +422,7 @@ static int ssb_gpio_extif_init(struct ssb_bus *bus) 
	chip->label		= "ssb_extif_gpio";

	chip->owner		= THIS_MODULE;

	chip->get		= ssb_gpio_extif_get_value;

	chip->set		= ssb_gpio_extif_set_value;

	chip->set_rv		= ssb_gpio_extif_set_value;

	chip->direction_input	= ssb_gpio_extif_direction_input;

	chip->direction_output	= ssb_gpio_extif_direction_output;

#if IS_ENABLED(CONFIG_SSB_EMBEDDED)