Commit 55fb52ff authored by Pauli Virtanen's avatar Pauli Virtanen Committed by Luiz Augusto von Dentz
Browse files

Bluetooth: MGMT: cancel mesh send timer when hdev removed 

mesh_send_done timer is not canceled when hdev is removed, which causes
crash if the timer triggers after hdev is gone.

Cancel the timer when MGMT removes the hdev, like other MGMT timers.

Should fix the BUG: sporadically seen by BlueZ test bot
(in "Mesh - Send cancel - 1" test).

Log:
------
BUG: KASAN: slab-use-after-free in run_timer_softirq+0x76b/0x7d0
...
Freed by task 36:
 kasan_save_stack+0x24/0x50
 kasan_save_track+0x14/0x30
 __kasan_save_free_info+0x3a/0x60
 __kasan_slab_free+0x43/0x70
 kfree+0x103/0x500
 device_release+0x9a/0x210
 kobject_put+0x100/0x1e0
 vhci_release+0x18b/0x240
------

Fixes: b338d917 ("Bluetooth: Implement support for Mesh")
Link: https://lore.kernel.org/linux-bluetooth/67364c09.0c0a0220.113cba.39ff@mx.google.com/


Signed-off-by: default avatarPauli Virtanen <pav@iki.fi>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent 96a9178a

net/bluetooth/mgmt.c

+1 −0
Original line number Diff line number Diff line
@@ -9497,6 +9497,7 @@ void mgmt_index_removed(struct hci_dev *hdev) 
	cancel_delayed_work_sync(&hdev->discov_off);

	cancel_delayed_work_sync(&hdev->service_cache);

	cancel_delayed_work_sync(&hdev->rpa_expired);

	cancel_delayed_work_sync(&hdev->mesh_send_done);

}



void mgmt_power_on(struct hci_dev *hdev, int err)