Commit 567a1e85 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Martin K. Petersen
Browse files

scsi: fcoe: Fix unsigned comparison with zero in store_ctlr_mode() 



ctlr->mode is of unsigned type, it is never less than zero.

Fix this by using an extra variable called 'res', to store return value
from sysfs_match_string() and assign that to ctlr->mode on the success
path.

Fixes: edc22a7c ("scsi: fcoe: Use sysfs_match_string() over fcoe_parse_mode()")
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20240102085245.600570-1-harshit.m.mogalapalli@oracle.com


Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 904fdd20

drivers/scsi/fcoe/fcoe_sysfs.c

+4 −2
Original line number Diff line number Diff line
@@ -263,6 +263,7 @@ static ssize_t store_ctlr_mode(struct device *dev, 
			       const char *buf, size_t count)

{

	struct fcoe_ctlr_device *ctlr = dev_to_ctlr(dev);

	int res;



	if (count > FCOE_MAX_MODENAME_LEN)

		return -EINVAL;
@@ -279,12 +280,13 @@ static ssize_t store_ctlr_mode(struct device *dev, 
			return -ENOTSUPP;

		}



		ctlr->mode = sysfs_match_string(fip_conn_type_names, buf);

		if (ctlr->mode < 0 || ctlr->mode == FIP_CONN_TYPE_UNKNOWN) {

		res = sysfs_match_string(fip_conn_type_names, buf);

		if (res < 0 || res == FIP_CONN_TYPE_UNKNOWN) {

			LIBFCOE_SYSFS_DBG(ctlr, "Unknown mode %s provided.\n",

					  buf);

			return -EINVAL;

		}

		ctlr->mode = res;



		ctlr->f->set_fcoe_ctlr_mode(ctlr);

		LIBFCOE_SYSFS_DBG(ctlr, "Mode changed to %s.\n", buf);