Commit 5694f274 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: sysfs: don't access gdev->chip if it's not needed 



Don't dereference gdev->chip if the same information can be obtained
from struct gpio_device.

Suggested-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 3c7a47f6

drivers/gpio/gpiolib-sysfs.c

+3 −3
Original line number Diff line number Diff line
@@ -403,7 +403,7 @@ static ssize_t base_show(struct device *dev, 
{

	const struct gpio_device *gdev = dev_get_drvdata(dev);



	return sysfs_emit(buf, "%d\n", gdev->chip->base);

	return sysfs_emit(buf, "%d\n", gdev->base);

}

static DEVICE_ATTR_RO(base);
@@ -412,7 +412,7 @@ static ssize_t label_show(struct device *dev, 
{

	const struct gpio_device *gdev = dev_get_drvdata(dev);



	return sysfs_emit(buf, "%s\n", gdev->chip->label ?: "");

	return sysfs_emit(buf, "%s\n", gdev->label);

}

static DEVICE_ATTR_RO(label);
@@ -421,7 +421,7 @@ static ssize_t ngpio_show(struct device *dev, 
{

	const struct gpio_device *gdev = dev_get_drvdata(dev);



	return sysfs_emit(buf, "%u\n", gdev->chip->ngpio);

	return sysfs_emit(buf, "%u\n", gdev->ngpio);

}

static DEVICE_ATTR_RO(ngpio);