Commit 572cd1d2 authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

kconfig: qconf: avoid unnecessary parentSelected() when ESC is pressed 



When the ESC key is pressed, the parentSelected() signal is currently
emitted for singleMode, menuMode, and symbolMode.

However, parentSelected() signal is functional only for singleMode.

In menuMode, the signal is connected to the goBack() slot, but nothing
occurs because configList->rootEntry is always &rootmenu.

In symbolMode (in the right pane), the parentSelected() signal is not
connected to any slot.

This commit prevents the unnecessary emission of the parentSelected()
signal.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 511ff539

scripts/kconfig/qconf.cc

+1 −1
Original line number Diff line number Diff line
@@ -724,7 +724,7 @@ void ConfigList::keyPressEvent(QKeyEvent* ev) 
	struct menu *menu;

	enum prop_type type;



	if (ev->key() == Qt::Key_Escape && mode != fullMode && mode != listMode) {

	if (ev->key() == Qt::Key_Escape && mode == singleMode) {

		emit parentSelected();

		ev->accept();

		return;