Commit 573c2d06 authored by Wenchao Hao's avatar Wenchao Hao Committed by Martin K. Petersen
Browse files

scsi: scsi_debug: Add param to control sdev's allow_restart 



Add new module param "allow_restart" to control scsi_device's allow_restart
flag. This flag determines if EH is triggered after a command completes
with sense_key 0x6, ASC 0x4 and ASCQ 0x2. EH would be triggered if
allow_restart=1 in this condition.

The new param can be used with the error injection capability to test how
commands completing with sense_key 0x6, ASC 0x4 and ASCQ 0x2 are handled.

Signed-off-by: default avatarWenchao Hao <haowenchao2@huawei.com>
Link: https://lore.kernel.org/r/20231010092051.608007-11-haowenchao2@huawei.com


Tested-by: default avatarDouglas Gilbert <dgilbert@interlog.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f084fe52

drivers/scsi/scsi_debug.c

+6 −0
Original line number Diff line number Diff line
@@ -843,6 +843,7 @@ static bool have_dif_prot; 
static bool write_since_sync;

static bool sdebug_statistics = DEF_STATISTICS;

static bool sdebug_wp;

static bool sdebug_allow_restart;

/* Following enum: 0: no zbc, def; 1: host aware; 2: host managed */

static enum blk_zoned_model sdeb_zbc_model = BLK_ZONED_NONE;

static char *sdeb_zbc_model_s;
@@ -5478,6 +5479,9 @@ static int scsi_debug_slave_configure(struct scsi_device *sdp) 
		sdp->no_uld_attach = 1;

	config_cdb_len(sdp);



	if (sdebug_allow_restart)

		sdp->allow_restart = 1;



	devip->debugfs_entry = debugfs_create_dir(dev_name(&sdp->sdev_dev),

				sdebug_debugfs_root);

	if (IS_ERR_OR_NULL(devip->debugfs_entry))
@@ -6202,6 +6206,7 @@ module_param_named(zone_cap_mb, sdeb_zbc_zone_cap_mb, int, S_IRUGO); 
module_param_named(zone_max_open, sdeb_zbc_max_open, int, S_IRUGO);

module_param_named(zone_nr_conv, sdeb_zbc_nr_conv, int, S_IRUGO);

module_param_named(zone_size_mb, sdeb_zbc_zone_size_mb, int, S_IRUGO);

module_param_named(allow_restart, sdebug_allow_restart, bool, S_IRUGO | S_IWUSR);



MODULE_AUTHOR("Eric Youngdale + Douglas Gilbert");

MODULE_DESCRIPTION("SCSI debug adapter driver");
@@ -6274,6 +6279,7 @@ MODULE_PARM_DESC(zone_cap_mb, "Zone capacity in MiB (def=zone size)"); 
MODULE_PARM_DESC(zone_max_open, "Maximum number of open zones; [0] for no limit (def=auto)");

MODULE_PARM_DESC(zone_nr_conv, "Number of conventional zones (def=1)");

MODULE_PARM_DESC(zone_size_mb, "Zone size in MiB (def=auto)");

MODULE_PARM_DESC(allow_restart, "Set scsi_device's allow_restart flag(def=0)");



#define SDEBUG_INFO_LEN 256

static char sdebug_info[SDEBUG_INFO_LEN];