Commit 576dac28 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Bjorn Andersson
Browse files

remoteproc: qcom_q6v5_mss: Drop redundant error printks in probe 



Do not print errors of getting clocks and regulators in probe twice:
once in q6v5_init_clocks() or q6v5_regulator_init() and then again in the
probe function.  This also avoids dmesg flood on deferred probe.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20241011-remote-proc-dev-err-probe-v1-7-5abb4fc61eca@linaro.org


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 63b07ee3

drivers/remoteproc/qcom_q6v5_mss.c

+6 −18
Original line number Diff line number Diff line
@@ -2020,42 +2020,32 @@ static int q6v5_probe(struct platform_device *pdev) 


	ret = q6v5_init_clocks(&pdev->dev, qproc->proxy_clks,

			       desc->proxy_clk_names);

	if (ret < 0) {

		dev_err(&pdev->dev, "Failed to get proxy clocks.\n");

	if (ret < 0)

		return ret;

	}

	qproc->proxy_clk_count = ret;



	ret = q6v5_init_clocks(&pdev->dev, qproc->reset_clks,

			       desc->reset_clk_names);

	if (ret < 0) {

		dev_err(&pdev->dev, "Failed to get reset clocks.\n");

	if (ret < 0)

		return ret;

	}

	qproc->reset_clk_count = ret;



	ret = q6v5_init_clocks(&pdev->dev, qproc->active_clks,

			       desc->active_clk_names);

	if (ret < 0) {

		dev_err(&pdev->dev, "Failed to get active clocks.\n");

	if (ret < 0)

		return ret;

	}

	qproc->active_clk_count = ret;



	ret = q6v5_regulator_init(&pdev->dev, qproc->proxy_regs,

				  desc->proxy_supply);

	if (ret < 0) {

		dev_err(&pdev->dev, "Failed to get proxy regulators.\n");

	if (ret < 0)

		return ret;

	}

	qproc->proxy_reg_count = ret;



	ret = q6v5_regulator_init(&pdev->dev,  qproc->active_regs,

				  desc->active_supply);

	if (ret < 0) {

		dev_err(&pdev->dev, "Failed to get active regulators.\n");

	if (ret < 0)

		return ret;

	}

	qproc->active_reg_count = ret;



	ret = q6v5_pds_attach(&pdev->dev, qproc->proxy_pds,
@@ -2065,10 +2055,8 @@ static int q6v5_probe(struct platform_device *pdev) 
		ret = q6v5_regulator_init(&pdev->dev,

					  qproc->fallback_proxy_regs,

					  desc->fallback_proxy_supply);

		if (ret < 0) {

			dev_err(&pdev->dev, "Failed to get fallback proxy regulators.\n");

		if (ret < 0)

			return ret;

		}

		qproc->fallback_proxy_reg_count = ret;

	} else if (ret < 0) {

		dev_err(&pdev->dev, "Failed to init power domains\n");