Unverified Commit 57b03022 authored by Thippeswamy Havalige's avatar Thippeswamy Havalige Committed by Krzysztof Wilczyński
Browse files

PCI: xilinx-cpm: Fix IRQ domain leak in error path of probe 



The IRQ domain allocated for the PCIe controller is not freed if
resource_list_first_type() returns NULL, leading to a resource leak.

This fix ensures properly cleaning up the allocated IRQ domain in
the error path.

Fixes: 49e427e6 ("Merge branch 'pci/host-probe-refactor'")
Signed-off-by: default avatarThippeswamy Havalige <thippeswamy.havalige@amd.com>
[kwilczynski: added missing Fixes: tag, refactored to use one of the goto labels]
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Link: https://lore.kernel.org/r/20250224155025.782179-2-thippeswamy.havalige@amd.com
parent 2014c95a

drivers/pci/controller/pcie-xilinx-cpm.c

+6 −4
Original line number Diff line number Diff line
@@ -583,15 +583,17 @@ static int xilinx_cpm_pcie_probe(struct platform_device *pdev) 
		return err;



	bus = resource_list_first_type(&bridge->windows, IORESOURCE_BUS);

	if (!bus)

		return -ENODEV;

	if (!bus) {

		err = -ENODEV;

		goto err_free_irq_domains;

	}



	port->variant = of_device_get_match_data(dev);



	err = xilinx_cpm_pcie_parse_dt(port, bus->res);

	if (err) {

		dev_err(dev, "Parsing DT failed\n");

		goto err_parse_dt;

		goto err_free_irq_domains;

	}



	xilinx_cpm_pcie_init_port(port);
@@ -615,7 +617,7 @@ static int xilinx_cpm_pcie_probe(struct platform_device *pdev) 
	xilinx_cpm_free_interrupts(port);

err_setup_irq:

	pci_ecam_free(port->cfg);

err_parse_dt:

err_free_irq_domains:

	xilinx_cpm_free_irq_domains(port);

	return err;

}