Commit 57bb13d7 authored by Alok Tiwari's avatar Alok Tiwari Committed by Jakub Kicinski
Browse files

iavf: clarify VLAN add/delete log messages and lower log level 



The current dev_warn messages for too many VLAN changes are confusing
and one place incorrectly references "add" instead of "delete" VLANs
due to copy-paste errors.

- Use dev_info instead of dev_warn to lower the log level.
- Rephrase the message to: "virtchnl: Too many VLAN [add|delete]
  ([v1|v2]) requests; splitting into multiple messages to PF\n".

Suggested-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Link: https://patch.msgid.link/20251125223632.1857532-12-anthony.l.nguyen@intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 1105a7a1

drivers/net/ethernet/intel/iavf/iavf_virtchnl.c

+8 −4
Original line number Diff line number Diff line
@@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter) 


		len = virtchnl_struct_size(vvfl, vlan_id, count);

		if (len > IAVF_MAX_AQ_BUF_SIZE) {

			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");

			dev_info(&adapter->pdev->dev,

				 "virtchnl: Too many VLAN add (v1) requests; splitting into multiple messages to PF\n");

			while (len > IAVF_MAX_AQ_BUF_SIZE)

				len = virtchnl_struct_size(vvfl, vlan_id,

							   --count);
@@ -838,7 +839,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter) 


		len = virtchnl_struct_size(vvfl_v2, filters, count);

		if (len > IAVF_MAX_AQ_BUF_SIZE) {

			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");

			dev_info(&adapter->pdev->dev,

				 "virtchnl: Too many VLAN add (v2) requests; splitting into multiple messages to PF\n");

			while (len > IAVF_MAX_AQ_BUF_SIZE)

				len = virtchnl_struct_size(vvfl_v2, filters,

							   --count);
@@ -941,7 +943,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter) 


		len = virtchnl_struct_size(vvfl, vlan_id, count);

		if (len > IAVF_MAX_AQ_BUF_SIZE) {

			dev_warn(&adapter->pdev->dev, "Too many delete VLAN changes in one request\n");

			dev_info(&adapter->pdev->dev,

				 "virtchnl: Too many VLAN delete (v1) requests; splitting into multiple messages to PF\n");

			while (len > IAVF_MAX_AQ_BUF_SIZE)

				len = virtchnl_struct_size(vvfl, vlan_id,

							   --count);
@@ -987,7 +990,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter) 


		len = virtchnl_struct_size(vvfl_v2, filters, count);

		if (len > IAVF_MAX_AQ_BUF_SIZE) {

			dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");

			dev_info(&adapter->pdev->dev,

				 "virtchnl: Too many VLAN delete (v2) requests; splitting into multiple messages to PF\n");

			while (len > IAVF_MAX_AQ_BUF_SIZE)

				len = virtchnl_struct_size(vvfl_v2, filters,

							   --count);