Commit 57f55048 authored by Lu Baolu's avatar Lu Baolu Committed by Joerg Roedel
Browse files

iommu/vt-d: Disallow dirty tracking if incoherent page walk 



Dirty page tracking relies on the IOMMU atomically updating the dirty bit
in the paging-structure entry. For this operation to succeed, the paging-
structure memory must be coherent between the IOMMU and the CPU. In
another word, if the iommu page walk is incoherent, dirty page tracking
doesn't work.

The Intel VT-d specification, Section 3.10 "Snoop Behavior" states:

"Remapping hardware encountering the need to atomically update A/EA/D bits
 in a paging-structure entry that is not snooped will result in a non-
 recoverable fault."

To prevent an IOMMU from being incorrectly configured for dirty page
tracking when it is operating in an incoherent mode, mark SSADS as
supported only when both ecap_slads and ecap_smpwc are supported.

Fixes: f35f22cc ("iommu/vt-d: Access/Dirty bit support for SS domains")
Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20250924083447.123224-1-baolu.lu@linux.intel.com


Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
parent 5bd5ab53

drivers/iommu/intel/iommu.h

+2 −1
Original line number Diff line number Diff line
@@ -537,7 +537,8 @@ enum { 
#define pasid_supported(iommu)	(sm_supported(iommu) &&			\

				 ecap_pasid((iommu)->ecap))

#define ssads_supported(iommu) (sm_supported(iommu) &&                 \

				ecap_slads((iommu)->ecap))

				ecap_slads((iommu)->ecap) &&           \

				ecap_smpwc(iommu->ecap))

#define nested_supported(iommu)	(sm_supported(iommu) &&			\

				 ecap_nest((iommu)->ecap))