Commit 583c58e3 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: iwlwifi: pcie: clear FW debug memory on init 



When we restart the firmware, we shouldn't keep old debug data
around. Since the "allocate" function might not reallocate the
memory block (it's only freed when we unbind from the device),
clear the memory to have a clean slate for debug data.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230613155501.73c32255a132.Ibd7101dcd285b01ee879fddfbf52c30d49ced3c0@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent c2a2f505

drivers/net/wireless/intel/iwlwifi/pcie/trans.c

+4 −5
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause

/*

 * Copyright (C) 2007-2015, 2018-2022 Intel Corporation

 * Copyright (C) 2007-2015, 2018-2023 Intel Corporation

 * Copyright (C) 2013-2015 Intel Mobile Communications GmbH

 * Copyright (C) 2016-2017 Intel Deutschland GmbH

 */
@@ -171,8 +171,10 @@ static void iwl_pcie_alloc_fw_monitor_block(struct iwl_trans *trans, 
	u32 size = 0;

	u8 power;



	if (fw_mon->size)

	if (fw_mon->size) {

		memset(fw_mon->block, 0, fw_mon->size);

		return;

	}



	for (power = max_power; power >= min_power; power--) {

		size = BIT(power);
@@ -215,9 +217,6 @@ void iwl_pcie_alloc_fw_monitor(struct iwl_trans *trans, u8 max_power) 
		 max_power))

		return;



	if (trans->dbg.fw_mon.size)

		return;



	iwl_pcie_alloc_fw_monitor_block(trans, max_power, 11);

}