Commit 586d8702 authored by Dmitry Safonov's avatar Dmitry Safonov Committed by Jakub Kicinski
Browse files

selftests/net: Add trace events matching to tcp_ao 



Setup trace points, add a new ftrace instance in order to not interfere
with the rest of the system, filtering by net namespace cookies.
Raise a new background thread that parses trace_pipe, matches them with
the list of expected events.

Wiring up trace events to selftests provides another insight if there is
anything unexpected happining in the tcp-ao code (i.e. key rotation when
it's not expected).

Note: in real programs libtraceevent should be used instead of this
manual labor of setting ftrace up and parsing. I'm not using it here
as I don't want to have an .so library dependency that one would have to
bring into VM or DUT (Device Under Test). Please, don't copy it over
into any real world programs, that aren't tests.

Signed-off-by: default avatarDmitry Safonov <0x7f454c46@gmail.com>
Link: https://patch.msgid.link/20240823-tcp-ao-selftests-upd-6-12-v4-8-05623636fe8c@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 044e0370

tools/testing/selftests/net/tcp_ao/Makefile

+2 −1
Original line number Diff line number Diff line
@@ -31,7 +31,8 @@ CFLAGS += $(KHDR_INCLUDES) 
CFLAGS	+= -iquote ./lib/ -I ../../../../include/



# Library

LIBSRC	:= kconfig.c netlink.c proc.c repair.c setup.c sock.c utils.c

LIBSRC	:= ftrace.c ftrace-tcp.c kconfig.c netlink.c

LIBSRC	+= proc.c repair.c setup.c sock.c utils.c

LIBOBJ	:= $(LIBSRC:%.c=$(LIBDIR)/%.o)

EXTRA_CLEAN += $(LIBOBJ) $(LIB)

tools/testing/selftests/net/tcp_ao/bench-lookups.c

+1 −1
Original line number Diff line number Diff line
@@ -355,6 +355,6 @@ static void *client_fn(void *arg) 


int main(int argc, char *argv[])

{

	test_init(30, server_fn, client_fn);

	test_init(31, server_fn, client_fn);

	return 0;

}

tools/testing/selftests/net/tcp_ao/config

+1 −0
Original line number Diff line number Diff line
@@ -7,4 +7,5 @@ CONFIG_NET_L3_MASTER_DEV=y 
CONFIG_NET_VRF=y

CONFIG_TCP_AO=y

CONFIG_TCP_MD5SIG=y

CONFIG_TRACEPOINTS=y

CONFIG_VETH=m

tools/testing/selftests/net/tcp_ao/connect-deny.c

+16 −2
Original line number Diff line number Diff line
@@ -215,30 +215,44 @@ static void try_connect(const char *tst_name, unsigned int port, 


static void *client_fn(void *arg)

{

	union tcp_addr wrong_addr, network_addr;

	union tcp_addr wrong_addr, network_addr, addr_any = {};

	unsigned int port = test_server_port;



	if (inet_pton(TEST_FAMILY, TEST_WRONG_IP, &wrong_addr) != 1)

		test_error("Can't convert ip address %s", TEST_WRONG_IP);



	trace_ao_event_expect(TCP_AO_KEY_NOT_FOUND, this_ip_addr, this_ip_dest,

			      -1, port, 0, 0, 1, 0, 0, 0, 100, 100, -1);

	try_connect("Non-AO server + AO client", port++, DEFAULT_TEST_PASSWORD,

			this_ip_dest, -1, 100, 100, 0, FAULT_TIMEOUT);



	trace_hash_event_expect(TCP_HASH_AO_REQUIRED, this_ip_addr, this_ip_dest,

				-1, port, 0, 0, 1, 0, 0, 0);

	try_connect("AO server + Non-AO client", port++, NULL,

			this_ip_dest, -1, 100, 100, 0, FAULT_TIMEOUT);



	trace_ao_event_expect(TCP_AO_MISMATCH, this_ip_addr, this_ip_dest,

			      -1, port, 0, 0, 1, 0, 0, 0, 100, 100, -1);

	try_connect("Wrong password", port++, DEFAULT_TEST_PASSWORD,

			this_ip_dest, -1, 100, 100, 0, FAULT_TIMEOUT);



	trace_ao_event_expect(TCP_AO_KEY_NOT_FOUND, this_ip_addr, this_ip_dest,

			      -1, port, 0, 0, 1, 0, 0, 0, 100, 100, -1);

	try_connect("Wrong rcv id", port++, DEFAULT_TEST_PASSWORD,

			this_ip_dest, -1, 100, 100, 0, FAULT_TIMEOUT);



	trace_ao_event_sk_expect(TCP_AO_SYNACK_NO_KEY, this_ip_dest, addr_any,

				 port, 0, 100, 100);

	try_connect("Wrong snd id", port++, DEFAULT_TEST_PASSWORD,

			this_ip_dest, -1, 100, 100, 0, FAULT_TIMEOUT);



	trace_ao_event_expect(TCP_AO_WRONG_MACLEN, this_ip_addr, this_ip_dest,

			      -1, port, 0, 0, 1, 0, 0, 0, 100, 100, -1);

	try_connect("Different maclen", port++, DEFAULT_TEST_PASSWORD,

			this_ip_dest, -1, 100, 100, 0, FAULT_TIMEOUT);



	trace_ao_event_expect(TCP_AO_KEY_NOT_FOUND, this_ip_addr, this_ip_dest,

			      -1, port, 0, 0, 1, 0, 0, 0, 100, 100, -1);

	try_connect("Server: Wrong addr", port++, DEFAULT_TEST_PASSWORD,

			this_ip_dest, -1, 100, 100, 0, FAULT_TIMEOUT);
@@ -262,6 +276,6 @@ static void *client_fn(void *arg) 


int main(int argc, char *argv[])

{

	test_init(21, server_fn, client_fn);

	test_init(22, server_fn, client_fn);

	return 0;

}

tools/testing/selftests/net/tcp_ao/connect.c

+1 −1
Original line number Diff line number Diff line
@@ -85,6 +85,6 @@ static void *client_fn(void *arg) 


int main(int argc, char *argv[])

{

	test_init(1, server_fn, client_fn);

	test_init(2, server_fn, client_fn);

	return 0;

}