Commit 5886cc8f authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Dmitry Baryshkov
Browse files

drm/msm/dpu: Don't use %pK through printk (again) 



In the past %pK was preferable to %p as it would not leak raw pointer
values into the kernel log.
Since commit ad67b74d ("printk: hash addresses printed with %p")
the regular %p has been improved to avoid this issue.
Furthermore, restricted pointers ("%pK") were never meant to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping locks in atomic contexts.

Switch to the regular pointer formatting which is safer and
easier to reason about.

This was previously fixed in this driver in commit 1ba9fbe4
("drm/msm: Don't use %pK through printk") but an additional usage
was reintroduced in commit 39a750ff ("drm/msm/dpu: Add DSPP GC
driver to provide GAMMA_LUT DRM property")

Signed-off-by: default avatarThomas Weißschuh <thomas.weissschuh@linutronix.de>
Fixes: 39a750ff ("drm/msm/dpu: Add DSPP GC driver to provide GAMMA_LUT DRM property")
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/706229/
Link: https://lore.kernel.org/r/20260223-restricted-pointers-msm-v1-1-14c0b451e372@linutronix.de


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
parent 9f593419

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c

+1 −1
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ static void dpu_setup_dspp_gc(struct dpu_hw_dspp *ctx, 
	base = ctx->cap->sblk->gc.base;



	if (!base) {

		DRM_ERROR("invalid ctx %pK gc base\n", ctx);

		DRM_ERROR("invalid ctx %p gc base\n", ctx);

		return;

	}