Unverified Commit 589c12ed authored by Dan Carpenter's avatar Dan Carpenter Committed by Christian Brauner
Browse files

coredump: Fix return value in coredump_parse() 



The coredump_parse() function is bool type.  It should return true on
success and false on failure.  The cn_printf() returns zero on success
or negative error codes.  This mismatch means that when "return err;"
here, it is treated as success instead of failure.  Change it to return
false instead.

Fixes: a5715af5 ("coredump: make coredump_parse() return bool")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/aKRGu14w5vPSZLgv@stanley.mountain


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 7375f224

fs/coredump.c

+1 −1
Original line number Diff line number Diff line
@@ -345,7 +345,7 @@ static bool coredump_parse(struct core_name *cn, struct coredump_params *cprm, 
				was_space = false;

				err = cn_printf(cn, "%c", '\0');

				if (err)

					return err;

					return false;

				(*argv)[(*argc)++] = cn->used;

			}

		}