Commit 58d4ca5b authored by David Yang's avatar David Yang Committed by Jakub Kicinski
Browse files

vxlan: vnifilter: fix memcpy with u64_stats 



On 64bit arches, struct u64_stats_sync is empty and provides no help
against load/store tearing. memcpy() should not be considered atomic
against u64 values. Use u64_stats_copy() instead.

Signed-off-by: default avatarDavid Yang <mmyangfl@gmail.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20260120092137.2161162-5-mmyangfl@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 35710f0d

drivers/net/vxlan/vxlan_vnifilter.c

+1 −1
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ static void vxlan_vnifilter_stats_get(const struct vxlan_vni_node *vninode, 
		pstats = per_cpu_ptr(vninode->stats, i);

		do {

			start = u64_stats_fetch_begin(&pstats->syncp);

			memcpy(&temp, &pstats->stats, sizeof(temp));

			u64_stats_copy(&temp, &pstats->stats, sizeof(temp));

		} while (u64_stats_fetch_retry(&pstats->syncp, start));



		dest->rx_packets += temp.rx_packets;