Commit 5906333c authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by David Sterba
Browse files

btrfs: zoned: don't skip block group profile checks on conventional zones 



On a zoned filesystem with conventional zones, we're skipping the block
group profile checks for the conventional zones.

This allows converting a zoned filesystem's data block groups to RAID when
all of the zones backing the chunk are on conventional zones.  But this
will lead to problems, once we're trying to allocate chunks backed by
sequential zones.

So also check for conventional zones when loading a block group's profile
on them.

Reported-by: default avatarHAN Yuwei <hrx@bupt.moe>
Link: https://lore.kernel.org/all/1ACD2E3643008A17+da260584-2c7f-432a-9e22-9d390aae84cc@bupt.moe/#t


Reviewed-by: default avatarBoris Burkov <boris@bur.io>
Reviewed-by: default avatarNaohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent b0ad381f

fs/btrfs/zoned.c

+9 −0
Original line number Diff line number Diff line
@@ -1656,6 +1656,15 @@ int btrfs_load_block_group_zone_info(struct btrfs_block_group *cache, bool new) 
	}



out:

	/* Reject non SINGLE data profiles without RST */

	if ((map->type & BTRFS_BLOCK_GROUP_DATA) &&

	    (map->type & BTRFS_BLOCK_GROUP_PROFILE_MASK) &&

	    !fs_info->stripe_root) {

		btrfs_err(fs_info, "zoned: data %s needs raid-stripe-tree",

			  btrfs_bg_type_to_raid_name(map->type));

		return -EINVAL;

	}



	if (cache->alloc_offset > cache->zone_capacity) {

		btrfs_err(fs_info,

"zoned: invalid write pointer %llu (larger than zone capacity %llu) in block group %llu",