Commit 593ee492 authored by Haotian Zhang's avatar Haotian Zhang Committed by Rafael J. Wysocki
Browse files

ACPI: property: Fix fwnode refcount leak in acpi_fwnode_graph_parse_endpoint() 



acpi_fwnode_graph_parse_endpoint() calls fwnode_get_parent() to obtain the
parent fwnode but returns without calling fwnode_handle_put() on it. This
potentially leads to a fwnode refcount leak and prevents the parent node
from being released properly.

Call fwnode_handle_put() on the parent fwnode before returning to prevent
the leak from occurring.

Fixes: 3b27d00e ("device property: Move fwnode graph ops to firmware specific locations")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
[ rjw: Changelog edits ]
Link: https://patch.msgid.link/20251111075000.1828-1-vulab@iscas.ac.cn


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent b889ed5a

drivers/acpi/property.c

+1 −0
Original line number Diff line number Diff line
@@ -1718,6 +1718,7 @@ static int acpi_fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode, 
	if (fwnode_property_read_u32(fwnode, "reg", &endpoint->id))

		fwnode_property_read_u32(fwnode, "endpoint", &endpoint->id);



	fwnode_handle_put(port_fwnode);

	return 0;

}