Unverified Commit 597ac0fa authored by Niklas Cassel's avatar Niklas Cassel Committed by Krzysztof Wilczyński
Browse files

PCI: endpoint: pci-epf-test: Clean up pci_epf_test_unbind() 

Clean up pci_epf_test_unbind() by using a continue if we did not allocate
memory for the BAR index. This reduces the indentation level by one.

This makes pci_epf_test_unbind() more similar to pci_epf_test_set_bar().

Link: https://lore.kernel.org/linux-pci/20240320113157.322695-6-cassel@kernel.org


Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent e49eab94

drivers/pci/endpoint/functions/pci-epf-test.c

+6 −8
Original line number Diff line number Diff line
@@ -690,22 +690,20 @@ static void pci_epf_test_unbind(struct pci_epf *epf) 
{

	struct pci_epf_test *epf_test = epf_get_drvdata(epf);

	struct pci_epc *epc = epf->epc;

	struct pci_epf_bar *epf_bar;

	int bar;



	cancel_delayed_work(&epf_test->cmd_handler);

	pci_epf_test_clean_dma_chan(epf_test);

	for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {

		epf_bar = &epf->bar[bar];

		if (!epf_test->reg[bar])

			continue;



		if (epf_test->reg[bar]) {

		pci_epc_clear_bar(epc, epf->func_no, epf->vfunc_no,

					  epf_bar);

				  &epf->bar[bar]);

		pci_epf_free_space(epf, epf_test->reg[bar], bar,

				   PRIMARY_INTERFACE);

	}

}

}



static int pci_epf_test_set_bar(struct pci_epf *epf)

{