Commit 5982a539 authored by Salah Triki's avatar Salah Triki Committed by Lizhi Hou
Browse files

accel/amdxdna: Delete pci_free_irq_vectors() 



The device is managed so pci_free_irq_vectors() is called automatically
no need to do it manually.

Reviewed-by: default avatarJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Signed-off-by: default avatarSalah Triki <salah.triki@gmail.com>
Signed-off-by: default avatarLizhi Hou <lizhi.hou@amd.com>
Link: https://lore.kernel.org/r/aHs8QAfUlFeNp7qL@pc
parent bd72d4ac

drivers/accel/amdxdna/aie2_pci.c

+2 −6
Original line number Diff line number Diff line
@@ -520,14 +520,14 @@ static int aie2_init(struct amdxdna_dev *xdna) 
	if (!ndev->psp_hdl) {

		XDNA_ERR(xdna, "failed to create psp");

		ret = -ENOMEM;

		goto free_irq;

		goto release_fw;

	}

	xdna->dev_handle = ndev;



	ret = aie2_hw_start(xdna);

	if (ret) {

		XDNA_ERR(xdna, "start npu failed, ret %d", ret);

		goto free_irq;

		goto release_fw;

	}



	ret = aie2_mgmt_fw_query(ndev);
@@ -578,8 +578,6 @@ static int aie2_init(struct amdxdna_dev *xdna) 
	aie2_error_async_events_free(ndev);

stop_hw:

	aie2_hw_stop(xdna);

free_irq:

	pci_free_irq_vectors(pdev);

release_fw:

	release_firmware(fw);
@@ -588,12 +586,10 @@ static int aie2_init(struct amdxdna_dev *xdna) 


static void aie2_fini(struct amdxdna_dev *xdna)

{

	struct pci_dev *pdev = to_pci_dev(xdna->ddev.dev);

	struct amdxdna_dev_hdl *ndev = xdna->dev_handle;



	aie2_hw_stop(xdna);

	aie2_error_async_events_free(ndev);

	pci_free_irq_vectors(pdev);

}



static int aie2_get_aie_status(struct amdxdna_client *client,