Unverified Commit 59abe7bc authored by Ranjani Sridharan's avatar Ranjani Sridharan Committed by Mark Brown
Browse files

ASoC: SOF: ipc3-topology: Fix multi-core and static pipelines tear down 



In the case of static pipelines, freeing the widgets in the pipelines
that were not suspended after freeing the scheduler widgets results in
errors because the secondary cores are powered off when the scheduler
widgets are freed. Fix this by tearing down the leftover pipelines before
powering off the secondary cores.

Cc: stable@vger.kernel.org
Fixes: d7332c4a ("ASoC: SOF: ipc3-topology: Fix pipeline tear down logic")
Signed-off-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://patch.msgid.link/20251002073125.32471-1-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f8b9c819

sound/soc/sof/ipc3-topology.c

+5 −5
Original line number Diff line number Diff line
@@ -2473,11 +2473,6 @@ static int sof_ipc3_tear_down_all_pipelines(struct snd_sof_dev *sdev, bool verif 
	if (ret < 0)

		return ret;



	/* free all the scheduler widgets now */

	ret = sof_ipc3_free_widgets_in_list(sdev, true, &dyn_widgets, verify);

	if (ret < 0)

		return ret;



	/*

	 * Tear down all pipelines associated with PCMs that did not get suspended

	 * and unset the prepare flag so that they can be set up again during resume.
@@ -2493,6 +2488,11 @@ static int sof_ipc3_tear_down_all_pipelines(struct snd_sof_dev *sdev, bool verif 
		}

	}



	/* free all the scheduler widgets now. This will also power down the secondary cores */

	ret = sof_ipc3_free_widgets_in_list(sdev, true, &dyn_widgets, verify);

	if (ret < 0)

		return ret;



	list_for_each_entry(sroute, &sdev->route_list, list)

		sroute->setup = false;