Commit 59dbee7d authored by Anna-Maria Behnsen's avatar Anna-Maria Behnsen Committed by Thomas Gleixner
Browse files

tick/sched: Combine WARN_ON_ONCE and print_once 



When the WARN_ON_ONCE() triggers, the printk() of the additional
information related to the warning will not happen in print level
"warn". When reading dmesg with a restriction to level "warn", the
information published by the printk_once() will not show up there.

Transform WARN_ON_ONCE() and printk_once() into a WARN_ONCE().

Signed-off-by: default avatarAnna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20240610103552.25252-1-anna-maria@linutronix.de
parent 2b83be20

kernel/time/tick-sched.c

+4 −4
Original line number Diff line number Diff line
@@ -1026,10 +1026,10 @@ static void tick_nohz_stop_tick(struct tick_sched *ts, int cpu) 
		if (expires == KTIME_MAX || ts->next_tick == hrtimer_get_expires(&ts->sched_timer))

			return;



		WARN_ON_ONCE(1);

		printk_once("basemono: %llu ts->next_tick: %llu dev->next_event: %llu timer->active: %d timer->expires: %llu\n",

			    basemono, ts->next_tick, dev->next_event,

			    hrtimer_active(&ts->sched_timer), hrtimer_get_expires(&ts->sched_timer));

		WARN_ONCE(1, "basemono: %llu ts->next_tick: %llu dev->next_event: %llu "

			  "timer->active: %d timer->expires: %llu\n", basemono, ts->next_tick,

			  dev->next_event, hrtimer_active(&ts->sched_timer),

			  hrtimer_get_expires(&ts->sched_timer));

	}



	/*