Commit 5a649837 authored by Alex Shi's avatar Alex Shi Committed by Ingo Molnar
Browse files

sched/fair: Remove unused parameter from sched_asym() 



The 'sds' argument is not used in the sched_asym() function anymore, remove it.

Fixes: c9ca0788 ("sched/fair: Do not even the number of busy CPUs via asym_packing")
Signed-off-by: default avatarAlex Shi <alexs@kernel.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarRicardo Neri <ricardo.neri-calderon@linux.intel.com>
Reviewed-by: default avatarValentin Schneider <vschneid@redhat.com>
Reviewed-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Link: https://lore.kernel.org/r/20240210113924.1130448-2-alexs@kernel.org
parent d654c8dd

kernel/sched/fair.c

+2 −4
Original line number Diff line number Diff line
@@ -9753,7 +9753,6 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) 
/**

 * sched_asym - Check if the destination CPU can do asym_packing load balance

 * @env:	The load balancing environment

 * @sds:	Load-balancing data with statistics of the local group

 * @sgs:	Load-balancing statistics of the candidate busiest group

 * @group:	The candidate busiest group

 *
@@ -9772,8 +9771,7 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) 
 * otherwise.

 */

static inline bool

sched_asym(struct lb_env *env, struct sd_lb_stats *sds,  struct sg_lb_stats *sgs,

	   struct sched_group *group)

sched_asym(struct lb_env *env, struct sg_lb_stats *sgs, struct sched_group *group)

{

	/* Ensure that the whole local core is idle, if applicable. */

	if (!sched_use_asym_prio(env->sd, env->dst_cpu))
@@ -9944,7 +9942,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, 
	/* Check if dst CPU is idle and preferred to this group */

	if (!local_group && env->sd->flags & SD_ASYM_PACKING &&

	    env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running &&

	    sched_asym(env, sds, sgs, group)) {

	    sched_asym(env, sgs, group)) {

		sgs->group_asym_packing = 1;

	}