Commit 5a83c929 authored by Imre Deak's avatar Imre Deak
Browse files

drm/nouveau/dp_mst: Expose a connector to kernel users after it's properly initialized 



After a connector is added to the drm_mode_config::connector_list, it's
visible to any in-kernel users looking up connectors via the above list.
Make sure that the connector is properly initialized before such
look-ups, by initializing the connector with
drm_connector_dynamic_init() - which doesn't add the connector to the
list - and registering it with drm_connector_dynamic_register() - which
adds the connector to the list - after the initialization is complete.

v2: Fix s/drm_connector_dynamic_register()/drm_connector_dynamic_init()
    typo in the commit log.

Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Acked-by: default avatarWayne Lin <Wayne.Lin@amd.com>
Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241211230328.4012496-8-imre.deak@intel.com
parent 550949c6

drivers/gpu/drm/nouveau/dispnv50/disp.c

+2 −2
Original line number Diff line number Diff line
@@ -1265,8 +1265,8 @@ nv50_mstc_new(struct nv50_mstm *mstm, struct drm_dp_mst_port *port, 
	mstc->mstm = mstm;

	mstc->port = port;



	ret = drm_connector_init(dev, &mstc->connector, &nv50_mstc,

				 DRM_MODE_CONNECTOR_DisplayPort);

	ret = drm_connector_dynamic_init(dev, &mstc->connector, &nv50_mstc,

					 DRM_MODE_CONNECTOR_DisplayPort, NULL);

	if (ret) {

		kfree(*pmstc);

		*pmstc = NULL;