Commit 5a905e33 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Jason Gunthorpe
Browse files

RDMA/hfi1: Constify struct mmu_rb_ops 



'struct mmu_rb_ops' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  10879	    164	      0	  11043	   2b23	drivers/infiniband/hw/hfi1/pin_system.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  10907	    140	      0	  11047	   2b27	drivers/infiniband/hw/hfi1/pin_system.o

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/b826dd05eefa5f4d6a7a1b4d191eaf37c714ed04.1719259997.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 4adcaf96

drivers/infiniband/hw/hfi1/mmu_rb.c

+1 −1
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ static unsigned long mmu_node_last(struct mmu_rb_node *node) 
}



int hfi1_mmu_rb_register(void *ops_arg,

			 struct mmu_rb_ops *ops,

			 const struct mmu_rb_ops *ops,

			 struct workqueue_struct *wq,

			 struct mmu_rb_handler **handler)

{

drivers/infiniband/hw/hfi1/mmu_rb.h

+2 −2
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ struct mmu_rb_handler { 
	/* Begin on a new cachline boundary here */

	struct rb_root_cached root ____cacheline_aligned_in_smp;

	void *ops_arg;

	struct mmu_rb_ops *ops;

	const struct mmu_rb_ops *ops;

	struct list_head lru_list;

	struct work_struct del_work;

	struct list_head del_list;
@@ -51,7 +51,7 @@ struct mmu_rb_handler { 
};



int hfi1_mmu_rb_register(void *ops_arg,

			 struct mmu_rb_ops *ops,

			 const struct mmu_rb_ops *ops,

			 struct workqueue_struct *wq,

			 struct mmu_rb_handler **handler);

void hfi1_mmu_rb_unregister(struct mmu_rb_handler *handler);

drivers/infiniband/hw/hfi1/pin_system.c

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ static int sdma_rb_evict(void *arg, struct mmu_rb_node *mnode, void *arg2, 
			 bool *stop);

static void sdma_rb_remove(void *arg, struct mmu_rb_node *mnode);



static struct mmu_rb_ops sdma_rb_ops = {

static const struct mmu_rb_ops sdma_rb_ops = {

	.filter = sdma_rb_filter,

	.evict = sdma_rb_evict,

	.remove = sdma_rb_remove,