Commit 5aac9532 authored by Dave Penkler's avatar Dave Penkler Committed by Greg Kroah-Hartman
Browse files

staging: gpib: Fix secondary address restriction 



GPIB secondary addresses have valid values between 0 and 31
inclusive. The Make Secondary Address function MSA, used to form
the protocol byte, was using the gpib_address_restrict function
erroneously restricting the address range to 0 through 30.

Remove the call to gpib_address_restrict and simply trim the
address to 5 bits.

Fixes: 2da03e7e ("staging: gpib: Add user api include files")
Signed-off-by: default avatarDave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250520155100.5808-1-dpenkler@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7a7f07f2

drivers/staging/gpib/uapi/gpib.h

+1 −1
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ static inline __u8 MTA(unsigned int addr) 


static inline __u8 MSA(unsigned int addr)

{

	return gpib_address_restrict(addr) | SAD;

	return (addr & 0x1f) | SAD;

}



static inline __u8 PPE_byte(unsigned int dio_line, int sense)