Commit 5acdc432 authored by Ma Ke's avatar Ma Ke Committed by Felix Fietkau
Browse files

wifi: mt76: mt7615: check devm_kasprintf() returned value



devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 0bb4e918 ("mt76: mt7615: fix hwmon temp sensor mem use-after-free")
Signed-off-by: default avatarMa Ke <make24@iscas.ac.cn>
Reviewed-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
Link: https://patch.msgid.link/20240905014753.353271-1-make24@iscas.ac.cn


Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent df6b0867
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -56,6 +56,9 @@ int mt7615_thermal_init(struct mt7615_dev *dev)

	name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7615_%s",
			      wiphy_name(wiphy));
	if (!name)
		return -ENOMEM;

	hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, dev,
						       mt7615_hwmon_groups);
	return PTR_ERR_OR_ZERO(hwmon);